Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Expo plugin configuration instructions #3383

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pwellner
Copy link

Description

Tiny clarification to Expo plugin doc

Checklist

  • [x ] I've read CONTRIBUTING.md

@mfazekas
Copy link
Contributor

@pwellner download and access token are different also install instructions are in our docs site.
https://rnmapbox.github.io/docs/install

@pwellner
Copy link
Author

pwellner commented Feb 19, 2024

Thanks @mfazekas ! I was a bit confused by these instructions.

Do you think this proposed change makes things more clear to someone just starting out?

@MoreSaltMoreLemon
Copy link

Thanks @mfazekas ! I was a bit confused by these instructions.

Do you think this proposed change makes things more clear to someone just starting out?

Thanks for suggesting these changes. I was trying to figure this out right now and fortunately found your PR.

I personally find this to be clearer, but the issue I ran into is actually discovery.

On the Installation instruction page there is no example of the actual usage of Mapbox.setAccessToken, there is only a mention at the top: "public token to use as accessToken when running the app".

In the examples on the website, the map initialization using setAccessToken is also not mentioned. It isn't even a result in the search function.

@mfazekas
Copy link
Contributor

Thanks @mfazekas ! I was a bit confused by these instructions.

Do you think this proposed change makes things more clear to someone just starting out?

Thanks @mfazekas ! I was a bit confused by these instructions.
Do you think this proposed change makes things more clear to someone just starting out?

Thanks for suggesting these changes. I was trying to figure this out right now and fortunately found your PR.

I personally find this to be clearer, but the issue I ran into is actually discovery.

On the Installation instruction page there is no example of the actual usage of Mapbox.setAccessToken, there is only a mention at the top: "public token to use as accessToken when running the app".

In the examples on the website, the map initialization using setAccessToken is also not mentioned. It isn't even a result in the search function.

Great point, we'd need an Adding a Map section where we show how to call setAccessToken and how to add a trivial MapView component.

@pwellner
Copy link
Author

pwellner commented Feb 20, 2024

Where should the changes be made?

In the maps repo here? https://github.com/pwellner/maps/blob/main/plugin/install.md

Or in the maps-docs repo here? https://github.com/pwellner/maps-docs/blob/main/docs/install.md

@mfazekas
Copy link
Contributor

@pwellner I'd like to focus the doc site more and make the repo docs just refer to the doc site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants